Very good contract for the Avalanche.
There's no realistic long term risk in this deal, an RFA with arb years or a UFA with MacKinnon's current production would probably get 6M this off season. The risk is all in the short term. The Avalanche gave up the extra 2M of cap space they might have gained in the short term on a bridge deal in order to get a possibly bargain 3 years down the line when MacKinnon would have been arbitration eligible and will have 4 years left on this deal.
With the BS that Avalanche fans have had to put up with concerning Ryan O'Reilly's contracts and now Tyson Barrie possibly only getting a short term extension through arbitration, getting the team's franchise player locked down for 7 years should be considered a huge positive.