Florida still has a federal tax that players have to fork out; on top of that their spending over there is in US dollars. Players playing in Canada spend in canadian dollars; look at the exchange rate and the lifestyle of hockey players I would assume in terms of spending power and earning pay in US dollars it is more beneficial to play in Canada.
In terms of tax stuff there are ways of getting away with the tax read the article below:
John Tavares Could Save Nearly $12 Million In Taxes On His New Contract
Only team(s) that can get away with the tax scenario are the teams that have no state-tax (Florida is one of them).
US federal income tax rates
2018-2019 Tax Brackets | Bankrate.com
Canadian federal income tax rates
Canadian income tax rates for individuals - current and previous years - Canada.ca
US federal tax rates are higher than Canadian federal income tax rates for income over 500K; only thing US citizens have over us is they are allowed to deduct interest payments on the mortgage while filing taxes while we in Canada get screwed!
BUT.... why the hell would a hockey player need to get a freakin' mortgage? they can freakin buy a house in a jiffy as soon as the signing bonuses clears for them
US personal Income Tax Rates by state
2019 State Income Tax Rates
Provincial and Territorial Tax rates in Canada
9.2.5 Provincial and territorial income tax - Canada.ca
of all the NHL provinces (ON, QC, BC, AB and MB) Ontario has the best offer thus far for hockey players IMO and if you are an american it is even better because you can do the stuff mentioned in the forbes article above to avoid paying huge taxes.
Of course majority of the people in both countries who are not earning millions get a huge middle finger from the gov't and we can't do much about it but hockey players are paid well and also provided many avenues to save in "taxes". One cannot obviously compete with no tax states in the US like Florida but...... relatively speaking given that roster make up is only 23 players; ON is not a bad place to play