Once you're a muli-millionaire, cost of living doesn't matter.
That isn't even close to accurate.
This might be the case for some hedge fund guys who will have a 40 year career.
A NHL player is lucky to have a 10 year career. 3 of those years are on ELC, unless they were a top 5 draft pick, will be a 3-5M contract with bonuses. And if you have to play a year or two in the minors, significantly less. And for most players, their 2nd contract will be a bridge style deal, 2-3 year deal. So, realistically, you are halfway through your playing career before you get a chance at huge dollars.
So, when you finally get to making that big money (which, you'll likely only get one bite at the apple), would you rather outlay, without even TAKING tax into consideration. (not just income, but property, etc)
300k downpayment on a 1.5M property in a "low"cost of income city (Buffalo, nashville, Raleigh, etc) OR a 800k downpayment on a roughly equivalent 4M property in San Jose, NYC, Boston. That is huge money. Then consider the costs you'll never recoup like property taxes, high sales taxes, cost of school tuition for kids....that shit adds up quick. This is why the mid cost, low tax cities like Raleigh, Tampa, Nashville, Dallas, Vegas, Phoenix (if they ever pull their head out of their ass and have a team) are going to be desirable locations for guys when they get their big contracts.
Playing forty games in NYS at ten percent means $50k for each million in taxes. No different from other teams in NY, Cali, Mass and Canada. That's before factoring in accountants for rich people. No need to make it political. We pay market rates.
The difference, of course, playing in NYC, Boston, Chicago, Toronto, LA, comes with a certain lifestyle. Amazing nightlife, top tier elite restaurants, etc. Buffalo is great...but it's a small market city with big city taxes. Buffalo is competing with Pittsburgh, Columbus, etc as cold weather small market cities. And they have a much higher income tax rate.
The "Buffalo tax" comes in this way:
If your wife don't like snowy winters, it doesn't matter how much they offer you. If you like bright lights and parties, Chippewa Street ain't gonna cut it. (If you like snake farms and cocaine, you're gonna hate it everywhere.)
But if you like suburbs, Buffalo suburbs are as good as any other suburbs anywhere in North America. Not all hockey players like that, but plenty do. Sun worshippers and party boys need not apply. If you focus on your job and try to keep some stability at home, then Buffalo is as good as any other NHL market.
Not a moral issue -- just a matter of taste.
You are vastly underselling the difference between living in Buffalo and elsewhere. Go listen to Berglund's interview on the cam and stick podcast. They gave an honest impression of the city from an outsider's perspective. Players don't leave the hotel. They order room service if they have to eat a meal while in the city.
Most players are 27-30 when they sign their big contract. A lot of them aren't married and aren't settling down yet. Buffalo presents:
Bad Weather for the time you HAVE to be there.
Big city tax rates
Small market amenities with no real downtown/nightlife.
Buffalo is a great place to raise a family and a great community. For most players...that is a post career concern.