That is all the negative headlines thrown into one posts, and the nuance within seems to really get lost when you focus the headlines without the actual underlying. Are all of those problems? Absolutely! It just misses out on some details.
Like US is consistently one of the wealthiest nations on earth and has one of the highest PPPs in the world. It is almost always top 10 where the competition is either Arab countries with extreme oil wealth... or natural resourse/banking heavy European countries (Switzerland, Norway, Luxembourg). In the Arab countries, there is a vast difference in standard of living and liberty. In the European countries, there is a different trade off. Should be noted a one off there is Ireland. The US absolutely has some affordability issues, but compared to many (vast majority) of places, the standard of living is on a different level. Even compared to western countries. IE the difference is wages, standard of living, and economy in general between US and Portugal is vast.
On housing, there certainly are affordability issues and supply issues especially on the coasts and in high demand cities. Seattle, Vancouver, London, Berlin, etc all face these issues. That also isn't all the US either. You can buy really nice places in the midwest very affordably. It is a nuanced topic that varies greatly by region in the US. Just like homelessness... in bigger cities it is absolutely an issue, in smaller cities it can be, but not nearly to the extent. You wouldn't think it given the microscope on the US, but the US actually has a lower homeless rate than Sweden, UK, Australia, and a number of other western countries. The US can absolutely do better, but it does a better job that gets portrayed.
On the statement of worrying about the world that kids grow up in, this is a worry as old as time. And we ALWAYS should be worried about it. We always should be striving to make things better. Today's worries thought don't take into account progress that has been made. 25 years ago in a number of states it was still illegal to be homosexual. 50 years ago, most states had laws like that. 100 years ago, it was illegal in my area for anybody that wasn't white to own property in the city. What type of world is that to live in? It sucks to have that history, but progress has been made. We certainly have backslides that happen (and I'd argue we are in a period of that), but going to a hockey saying... development isn't linear. To only look forward at the problems is to ignore the progress of the past.
We could go back and forth on a number of these issues and there is plenty of good, and plenty of bad out there for the US. It is a varying shade of grey and a very nuanced topic. Along with that, the US is an enormous country with a lot of regional differences. The broad strokes can't really get a picture of the whole US. There are plenty of places I would never want to live in the US (like Memphis.... oooff), but there are some amazing places too.