CLC - there is a ridiculous amount of detail for the specifics, but IMO the bolded is the most important aspect. All players are taxed based on what they earn for playing the game in their local taxing authority. So when FLA plays a road game in NYC - they pay NYC tax on what they earn for that game. Teams in "no income tax states" receive an advantage because a higher % of their games are played in the "no state tax" situation, so they get more of a benefit of that. It gets more complicated by city income taxes in some juridictions, and the difference between US & CAN federal tax rates as well.
I would say that there is a ton of "nuance", and that there isn't a simple answer to the real difference without having access to players actual returns. With that said - if you do a simple theoretical recalculation assuming a 8% average state income tax rate (which seems high - but estimated high to maximize the impact) and FLA team playing 43 games (41 home games + 2 road games vs. TB/FLA) in tax free state vs. 4 for a NY team (2 road games vs. TB/FLA) it comes out a ~3% difference, which would equate to $100K for an average player salary ($3.5M). Lots of estimates included there, but it should be "materially" correct for overall analysis purposes.
Nope, it's not "materially correct", even from a financial perspective. There are sales tax differentials between states, property tax differentials (players gotta live somewhere!), and typically the no income-tax states have higher sales/property taxes to make up that revenue.
Now let's look at individuals' specific tax situations: Are they getting signing bonuses? Is their place of residence somewhere else, subjecting the SB to a different tax rate? Are they donating to reduce their tax liability? Are they shifting income to various tax-advantaged accounts?
And that's not even getting into all the non-financial factors a player would weight when choosing a team. Like team fit, culture, winning, weather, proximity to home/family.
There is no realistic way to "equalize" all these things. And to pretend to think you can belies belief.