Ok, ya, not as many live gigs these days to be sure, certainly not the golden era of jazz (what's that, the 30s?)
Making a living in music is certainly tough. You can teach, you can try to be a session musician, you can do weddings and church worship gigs, but clubs are not as common a source of income.
Agree about there being no substitute for a good teacher, I just mean the base level accessibility to educational content is far better. When I was a kid, if I wanted to learn a song, I might be able to find a tab of it on a bulletin board (pre-internet becoming mainstream...), a youtube lesson is far better than a sketchy tab. Not as good as being taught at Berkley, but hey, it's free and at your fingertips. There are actually some pretty good youtubers that do educational content of all styles and skill levels,
Golden era of jazz was 1930s. I would have loved to been around then.
I’ve known some very talented musicians over the years. Some of these guys are the hired gun guitarists who very popular, well known bands pick up when they tour a certain region. They are at the top of their trade. They can play anything.
But, even a lot of very talented musicians don’t make a lot of money even if they play a fair amount of gigs. They usually teach to supplement their income, and/or have a rich (or better off) spouse LOL.
Any method of learning is good. I use internet videos myself. But, then again, I use a wide variety of methods. Just as long as I’m learning, that’s the main objective. How you do it is less important than just doing it and you are learning & improving regardless of method.
But, if you have a good instructor, there are certain advantages which I've discovered over the 60 years or so that I’ve been playing. They can see you playing and correct mistakes i.e., move your 3rd finger from the 7th fret of the B string to the 7th fret of the G string. Or, if you play this variation of the chord instead, you can just lift your finger off the F on the first string to get an open E note of the 1st string which is the next note in the melody. They can tell you that this section has a ii chord followed by a V chord, but the artist has done a tri-tone substitution of the F dominant 7 to a Bb7. You can save some time when an instructor knows their stuff and explains these kinds of things to you.
I find the best YouTube videos are the ones that also have a tab or the sheet music besides watching them play. You can’t always tell if a specific note is actually being played because fingers that are needed for that chord can block the actual notes being played, so you just can’t tell (in essence, you can’t see all the notes being played). That’s where the tab comes in handy, or the sheet music, but not all videos have that. Tab is good, and actual traditional music notation (sheet music) is the also very good (sometimes, or often better even) because it accurately spells out how long each note or rest is played. I use tab a lot, but often use the sheet music to give me the necessary rhythmic info. That’s why I mentioned the Real Book in a previous post.
One question I asked was if anybody plays chord-melody. A lot of these ideas or concepts I’ve mentioned in earlier posts come into effect if you play chord-melody. I enjoy the challenge of merging, engineering and combining the melody with the chords of a song. It presents the full picture of the song and yet (from a guitar perspective) it's just one person playing guitar that is generating the end result.